Markets - Buy/Sell/Earn/Trade Buttons #5435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jon-edge
changed the title
swansontec
requested changes
Jan 25, 2025
| return isStakingSupported | ||
| } | ||
|
|
||
| // TODO: Broken - We need to come up with a wallet beforehand in order to get stakePlugins and stakePolicies for routing |
There was a problem hiding this comment.
It looks like you solved this, and it's not broken anymore?
There was a problem hiding this comment.
No this is still broken, I wanted to get the review out first while I continue to tackle it
Jon-edge
changed the title
Jon-edge
force-pushed
the
jon/markets-trade-buttons
branch
2 times, most recently
from
2ecb2c5 to
9fe064a
Compare
swansontec
requested changes
Jan 30, 2025
Jon-edge
force-pushed
the
jon/markets-trade-buttons
branch
3 times, most recently
from
f5121b7 to
84660da
Compare
swansontec
approved these changes
Jan 30, 2025
Jon-edge
force-pushed
the
jon/markets-trade-buttons
branch
from
84660da to
1d75f69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: Fix Earn button functionality
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: