-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Abstract L2 #5446
Abstract L2 #5446
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The chainCode
seems wrong. Also, please drop the first commit, or replace it with the upgrade to edge-currency-accountbased.
@@ -183,6 +183,19 @@ export const getSpecialCurrencyInfo = (pluginId: string): SpecialCurrencyInfo => | |||
export const SPECIAL_CURRENCY_INFO: { | |||
[pluginId: string]: SpecialCurrencyInfo | |||
} = { | |||
abstract: { | |||
allowZeroTx: true, | |||
chainCode: 'ETH', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is used for FIO. Does FIO support Abstract? If so, is this the code they use?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if FIO supports Abstract or not. I copied the chainCode from all the other EVM based SpecialCurrencyInfo
s. Do these other configs need fixing too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most likely you have found a bug!
e0a4c13
to
24985f1
Compare
24985f1
to
cf3ce5b
Compare
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: