Do not emit events until JavaScript is ready #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the synchronizer is running in the background, but the app does a hot-reload, we need to stop sending events until JavaScript is ready again.
swansontec
force-pushed
the
william/fix-yellow-warning
branch
from
653e8ba to
576935b
Compare
samholmes
approved these changes
May 17, 2024
Comment on lines
+449
to
+453
| override func startObserving() -> Void { | ||
| hasListeners = true | ||
| } | ||
|
|
||
| override func stopObserving() -> Void { |
There was a problem hiding this comment.
Where are startObserving and stopObserving called?
There was a problem hiding this comment.
These override methods in the React Native base class. React Native calls them to let us know when it's ready or not. If we fire an event when React Native is not ready, then React Native itself will throw an error. The error will either be a yellow box on the JavaScript side, or a kill-the-whole-app crash on the native side.
|
I approved it because it makes sense to add this to the library, but it really is up to the user of the lib to make sure these methods are called when it is determined that receiving an event would crash or not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the synchronizer is running in the background, but the app does a hot-reload, we need to stop sending events until JavaScript is ready again.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
Same thing for priatechain: EdgeApp/react-native-piratechain#11
Description
none