Translate Flag, Flags etc at CloudBuild page

[HThuren]

Here I make possible to translate at CloudBuildpage.

"Add flag": "Add flag",
"Flag": "Flag",
"Flags": "Flags",
"Missing flag": "Missing flag",
"Missing value": "Missing value",
"Value": "Value",

Maybe translate own:

• @zyren ZH
• @HThuren DA
• @ParkerEde / @TheIsotopes / @froqstar DE
• @Luznatural ES
• @Pat6874 FR
• @robustini IT
• @ulfhedlund SV
• @kobakirill RU
• @kobakirill BE
• @ypogribnyi UK

[robustini]

IT

"Add flag": "Aggiungi flag",
"Flag": "Flag",
"Flags": "Flags",
"Missing flag": "Flag assente",
"Missing value": "Valore assente",
"Value": "Valore",

[Pat6874]

FR: "Add flag": "Ajout drapeau", "Flag": "Drapeau", "Flags": "Drapeaux", "Missing flag": "Drapeau absent", "Missing value": "Valeur absente", "Value": "Valeur", Le dim. 2 févr. 2025 à 17:52, HThuren ***@***.***> a écrit :

…

Here I make possible to translate at CloudBuildpage. "Add flag": "Add flag", "Flag": "Flag", "Flags": "Flags", "Missing flag": "Missing flag", "Missing value": "Missing value", "Value": "Value", Maybe translate own: @zyren <https://github.com/zyren> ZH @HThuren <https://github.com/HThuren> DA @ParkerEde <https://github.com/ParkerEde> / @TheIsotopes <https://github.com/TheIsotopes> / @froqstar <https://github.com/froqstar> DE @Luznatural <https://github.com/Luznatural> ES @Pat6874 <https://github.com/Pat6874> FR @robustini <https://github.com/robustini> IT @ulfhedlund <https://github.com/ulfhedlund> SV @kobakirill <https://github.com/kobakirill> RU BE ? CS ? ------------------------------ You can view, comment on, or merge this pull request online at: #92 Commit Summary - f991111 <f991111> Translate Flag, Flags etc at CloudBuild page File Changes (11 files <https://github.com/EdgeTX/buddy/pull/92/files>) - *M* locales/be/flashing.json <https://github.com/EdgeTX/buddy/pull/92/files#diff-73efc60341fe6bda8a644bc2b85e392a08d069fd109793cdf6bc49708b2856b2> (6) - *M* locales/cs/flashing.json <https://github.com/EdgeTX/buddy/pull/92/files#diff-e629d38708f0e38df58655bdb9309d4d2424acd91ec096e2ad5295583d522897> (6) - *M* locales/da/flashing.json <https://github.com/EdgeTX/buddy/pull/92/files#diff-73bce46d9c34b53a2ffa87c4ee005b5977b7362beef4384c1072d76f18436f88> (6) - *M* locales/de/flashing.json <https://github.com/EdgeTX/buddy/pull/92/files#diff-c2db7e5cdd8441d81c68442ae973fb49810abd787abe64b51114c61098bf9b69> (6) - *M* locales/es/flashing.json <https://github.com/EdgeTX/buddy/pull/92/files#diff-d2badd9cb46569ce75134833dea918f291741f5007bafd99dfe5aa8e40af15a1> (6) - *M* locales/fr/flashing.json <https://github.com/EdgeTX/buddy/pull/92/files#diff-b4b73e655d677f1d0e37b855104834bdbe4c69ff8b3b77bb7f6bee790357ccbd> (6) - *M* locales/it/flashing.json <https://github.com/EdgeTX/buddy/pull/92/files#diff-db34e6d3bc7f99481dc44a3b58b009a05e83c67c8131db77e017503312557cb9> (6) - *M* locales/ru/flashing.json <https://github.com/EdgeTX/buddy/pull/92/files#diff-013ebc2449a7fe5ded0341ad21aa41f9f8541df7738f86791b1321a61ab25542> (6) - *M* locales/sv/flashing.json <https://github.com/EdgeTX/buddy/pull/92/files#diff-f796f2d3946635bd39305cc1b65173545f56beaffc9d61e1f3c3ff56ef02e7b1> (6) - *M* locales/zh/flashing.json <https://github.com/EdgeTX/buddy/pull/92/files#diff-2c9425c47fbf65089f31f1a26f352d2ef561181074be79ea7a71ff041b0b05f9> (6) - *M* src/renderer/components/CloudVersionTargetForm.tsx <https://github.com/EdgeTX/buddy/pull/92/files#diff-8413a01b36c83c9f4656a52c0e3d3bcceee645c4a860e120df6fcfe776c9eed1> (19) Patch Links: - https://github.com/EdgeTX/buddy/pull/92.patch - https://github.com/EdgeTX/buddy/pull/92.diff — Reply to this email directly, view it on GitHub <#92>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A6HE7XNBF34HFPVILRSGT632NZEOPAVCNFSM6AAAAABWKSLTPWVHI2DSMVQWIX3LMV43ASLTON2WKOZSHAZDKOBZHAZDAOI> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[ulfhedlund]

SE:
"Add flag": "Addera flagga",
"Flag": "Flagga",
"Flags": "Flaggor",
"Missing flag": "Flagga saknas",
"Missing value": "Värde saknas",
"Value": "Värde",

[HThuren]

@pfeerick seems that building env missing some libs, in e2e-web and preview-web. No issue to compile locally

error message in e2e-web run:

Package libasound2 is a virtual package provided by:
liboss4-salsa-asound2 4.2-build2020-1ubuntu3
libasound2t64 1.2.11-1build2 (= 1.2.11-1build2)

Package libicu70 is not available, but is referred to by another package.
This may mean that the package is missing, has been obsoleted, or
is only available from another source

E: Package 'libasound2' has no installation candidate
E: Package 'libicu70' has no installation candidate
E: Unable to locate package libffi7
E: Unable to locate package libx264-163
Failed to install browsers
Error: Installation process exited with code: 100
Error: Process completed with exit code 1.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.44%. Comparing base (6810861) to head (c247c9b).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
+ Coverage   39.53%   41.44%   +1.90%     
==========================================
  Files         103      103              
  Lines       12009    12010       +1     
  Branches      490      521      +31     
==========================================
+ Hits         4748     4977     +229     
+ Misses       7254     7024     -230     
- Partials        7        9       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[HThuren]

I really don't understand the issue from Codecov Report, anyone ?

[pfeerick]

It is telling you that there are no unit tests covering those changes / testing that your changes don't break existing behaviour. If you have look at the messages in the "Files Changed" tab of the PR, you'll see comments by the CodeCov action as to which lines it is commenting on.

[Luznatural]

ES:

"Add flag": "Añadir flag",
"Flag": "Flag",
"Flags": "Flags",
"Missing flag": "Flag ausente",
"Missing value": "Valor ausente",
"Value": "Valor",

[zyren]

ZH:

---

"Add flag": "添加标志",
"Flag": "标志",
"Flags": "标志",
"Missing flag": "缺失标志",
"Missing value": "缺失值",
"Value": "值",

[pfeerick]

@pfeerick seems that building env missing some libs, in e2e-web and preview-web. No issue to compile locally

If you rebase on current main this should go away - it was due to upstream change in GitHub (changing from ubuntu-22.04 to ubuntu-24.04). You will then only hit the checks error related to this being done in a fork rather than in the buddy repo, but that is a known issue that is easy to see.

[freshollie]

Happy with this change. Annoying that preview runs don't work from forks yet. @pfeerick another option for your PR is to change the checkout step to "checkout PR" when doing pull requests.

[ParkerEde]

DE:
"Add flag": "Schalter hinzufügen",
"Flag": "Schalter",
"Flags": "Schalter",
"Missing flag": "Fehlender Schalter",
"Missing value": "Fehlender Wert",
"Value": "Wert",

[HThuren]

@pfeerick seems that building env missing some libs, in e2e-web and preview-web. No issue to compile locally

If you rebase on current main this should go away - it was due to upstream change in GitHub (changing from ubuntu-22.04 to ubuntu-24.04). You will then only hit the checks error related to this being done in a fork rather than in the buddy repo, but that is a known issue that is easy to see.

I started with at fresh pull from main, and rebase are up to date, and stille have this issue. My commit only works with --no-verify, maybe that are a track to follow

[pfeerick]

It looks like something wasn't synced properly on your end still, as both your main and PR branches were one commit behind ;) Do you know to pull from the upstream branch, in order to keep your forks copy of main in sync with the upstream repo?

[pfeerick]

Please revert / stop pushing changes to src/shared/backend/__tests__/__snapshots__/sdcard.spec.ts.snap, as you are including invalid paths in those changes (hence why the tests is also failing, rather than just preview-web).

[HThuren]

Please revert / stop pushing changes to src/shared/backend/__tests__/__snapshots__/sdcard.spec.ts.snap, as you are including invalid paths in those changes (hence why the tests is also failing, rather than just preview-web).

yes I struggle with that, now just deleted the unwanted file in pull, sorry you have to deal with this

[pfeerick]

When you commit changes, you should have the option of selecting what files to include in the commit... simply don't add / unselect the ones that are only relevant to your system. What software do you use to submit / track changes?

[HThuren]

When you commit changes, you should have the option of selecting what files to include in the commit... simply don't add / unselect the ones that are only relevant to your system. What software do you use to submit / track changes?

I use git in cygwin64 terminal

... and yes I was stupid and used git add .

[pfeerick]

Yeah, done that myself (add all changes)... and it's fun (not!) trying to undo it sometimes, especially around submodules or irrelevant OS file changes.

[HThuren]

@pfeerick sorry, but regarding codecov telling test are missing, but where to add more test, can't see other test constructions

[pfeerick]

I wouldn't worry about it... the only tests I care about atm are the ones done as part of the tests stage of the GitHub action... (and the action generally)... which are all passing.

 ✓ src/shared/backend/__tests__/firmware.spec.ts  (12 tests) 693ms
 ✓ src/shared/backend/__tests__/flash.spec.ts  (12 tests) [11](https://github.com/EdgeTX/buddy/actions/runs/13218759274/job/36901220073#step:5:12)56ms
 ✓ src/shared/backend/__tests__/cloudbuild.spec.ts  (2 tests) 169ms
 ✓ src/renderer/components/__tests__/VersionTargetForm.spec.tsx  (8 tests) 788ms
 ✓ src/shared/backend/__tests__/sdcard.spec.ts  (31 tests) 5114ms
 ✓ src/renderer/pages/flash/__tests__/FlashingWizard.spec.tsx  (7 tests) 2229ms
 ✓ src/renderer/components/devices/__tests__/DeviceSelector.spec.tsx  (7 tests) 980ms
 ✓ src/webworker/__test__/backend-worker.spec.ts  (5 tests) 410ms
 ✓ src/renderer/components/firmware/__tests__/FirmwareSummary.spec.tsx  (6 tests) 4[12](https://github.com/EdgeTX/buddy/actions/runs/13218759274/job/36901220073#step:5:13)ms
 ✓ src/renderer/compatibility/__tests__/CompatNoticeHandler.spec.tsx  (6 tests) 390ms
 ✓ src/renderer/components/firmware/__tests__/CopyUrlButton.spec.tsx  (4 tests) 233ms
 ✓ src/renderer/components/devices/__tests__/DeviceList.spec.tsx  (4 tests) 264ms
 ✓ src/renderer/components/firmware/__tests__/DownloadFirmwareButton.spec.tsx  (2 tests) 187ms
 ✓ src/renderer/components/flashing/__tests__/FlashButton.spec.tsx  (2 tests) 1[18](https://github.com/EdgeTX/buddy/actions/runs/13218759274/job/36901220073#step:5:19)ms
 ✓ src/renderer/components/devices/__tests__/DeviceSummary.spec.tsx  (2 tests) 338ms
 ✓ src/renderer/components/__tests__/WindowsNav.spec.tsx  (3 tests) 83ms
 ✓ src/renderer/components/__tests__/SettingsMenu.spec.tsx  (2 tests) 247ms
 ✓ src/renderer/components/__tests__/Markdown.spec.tsx  (1 test) 87ms

[kobakirill]

RU
"Add flag": "Добав флаг",
"Flag": "Флаг",
"Flags": "Флаги",
"Missing flag": "Отсут флаг",
"Missing value": "Отсут значение",
"Value": "Значение",

[kobakirill]

BE
"Add flag": "Дадаць сцяг",
"Flag": "Сцяг",
"Flags": "Сцягі",
"Missing flag": "Адсут сцяг",
"Missing value": "Адсут значэнне",
"Value": "Значэнне",

[pfeerick]

Since it looks like we've probably had all the translations we're going to, this can be merged when you say when ;)

[pfeerick]

btw, you pushed src/shared/backend/__tests__/__snapshots__/sdcard.spec.ts.snap again 😇

[HThuren]

@pfeerick believe the pull are ready to merge, please review

[HThuren]

btw, you pushed src/shared/backend/__tests__/__snapshots__/sdcard.spec.ts.snap again 😇

yes , but now a copy from main branch

[pfeerick]

LGTM, and thanks for adding the tests for this... looks like some 41% of the codebase is covered by tests now :)