Skip to content

Commit

Permalink
fix: Remove 'v' prefix from release VERSION
Browse files Browse the repository at this point in the history
Since the command is only executed when the GITHUB_REF has a specific
prefix, I think it's fine to strip exactly that prefix.

Performing the change in the release workflow allows the release.sh script
to keep treating the VERSION as an opaque string.
  • Loading branch information
gonzalo-bulnes committed Jan 5, 2024
1 parent 3093192 commit 192f4ff
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/build_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:

- name: Set VERSION if tagged build
if: startsWith(github.event.ref, 'refs/tags/v')
run: echo "VERSION=${GITHUB_REF#refs/*/}" >> $GITHUB_ENV
run: echo "VERSION=${GITHUB_REF#refs/tags/v}" >> $GITHUB_ENV

- name: Build the release zip packages
if: github.event_name != 'pull_request'
Expand Down

0 comments on commit 192f4ff

Please sign in to comment.