Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove 'v' prefix from release VERSION #93

Merged
merged 1 commit into from
Jan 6, 2024
Merged

fix: Remove 'v' prefix from release VERSION #93

merged 1 commit into from
Jan 6, 2024

Conversation

gonzalo-bulnes
Copy link
Contributor

Fixes #73

Details in the commit message.

@gonzalo-bulnes
fix: Remove 'v' prefix from release VERSION
192f4ff 
Since the command is only executed when the GITHUB_REF has a specific
prefix, I think it's fine to strip exactly that prefix.

Performing the change in the release workflow allows the release.sh script
to keep treating the VERSION as an opaque string.
@gonzalo-bulnes
Copy link
Contributor Author

gonzalo-bulnes commented Jan 5, 2024 •
edited
Loading

@pfeerick I left a question in the issue to make sure I understand it correctly.

And I opened this as a draft because I'm not sure how to test it**, but I guess maybe you can.

** Well, VERSION="v1.2.4v"; echo ${VERSION#v} works as expected but I haven't tested it in the context of the workflow.

@pfeerick
Copy link
Member

pfeerick commented Jan 6, 2024

That should do the trick... GITHUB_REF is supposed to be formatted like refs/tags/<tag_name>, so v2.9.0 should equate to GITHUB_REF=refs/tags/v2.9.0. Only real way to test this will probably be to actually use it, and see if it works or breaks (and then send to purgatory along with all the other badly behaved code).

@gonzalo-bulnes gonzalo-bulnes marked this pull request as ready for review January 6, 2024 07:46
@gonzalo-bulnes
Copy link
Contributor Author

gonzalo-bulnes commented Jan 6, 2024 •
edited
Loading

Only real way to test this will probably be to actually use it, and see if it works or breaks (and then send to purgatory along with all the other badly behaved code).

Not a bad plan IMHO. 👍 I'm marking it as ready for review (not draft).

@pfeerick pfeerick merged commit 19c83e8 into EdgeTX:main Jan 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

release builder should strip v from version tag
2 participants
@gonzalo-bulnes @pfeerick