refactor(color): Use LVGL styles and objects for UI, legacy cleanup

[philmoz]

This is a big refactor of the color UI code - hopefully without breaking too much; but there are bound to be some teething problems.

Main goals:

• Use LVGL styles and objects for UI
• Consistency
• Cleanup legacy code
• Groundwork for 3.0

For the most part things should look pretty much the same; however there are a few UI changes to note.

Focus border has been made thicker to be more visible:

Text color on active item is PRIMARY1:

Tick marks on sliders display over slider bar:

When editing screen layouts the selected widget has the solid border and the others have a dashed border:

Topbar battery icon shows battery level as a colored bar - green >= 60%, amber 25% - 59%, red < 25% (these are LVGL, not theme colors):

Timer widget count up/down bar uses an LVGL arc instead of a PNG image.:

Guage widget % value moved to above the bar - LVGL has no equivalent to the invertRect() function previously used.

[pfeerick]

From the screenshots, a lot of this looks better. However, till will have to wait until we branch off for 2.10 for merge, given the amount of change involved.

@JimB40 I noticed in #3220 you never did anything for the mixer lines... any thoughts re: changing the active mixer line font color to PRIMARY1?

[philmoz]

Updated USB SD connected display:

[raphaelcoeffic]

@philmoz looks good to me! Looks like tremendous amount of work!

[philmoz]

As of last commit this is now 18K smaller than current main on TX16S.

[philmoz]

Using one of the debug tools in LVGL it's possible to visualise the screen redraw/refresh overhead.
In the videos below, LVGL changes the color of any screen area that is being redrawn.

2.9 - yikes!:
https://github.com/EdgeTX/edgetx/assets/9474356/26149f2f-d7cc-4c3a-b9d9-daf25420d57e

2.10 main branch - better:
https://github.com/EdgeTX/edgetx/assets/9474356/874db46c-eb3d-4312-bd28-3dcfa9a0de7f

This PR:
https://github.com/EdgeTX/edgetx/assets/9474356/e9838ac8-3148-4cd6-bfd4-402d31efa682

Lua widgets still redraw every 100ms (or so) - we really need a better display API for Lua apps.

[richardclli]

So there will be a performance boost after this PR is applied?

Using one of the debug tools in LVGL it's possible to visualise the screen redraw/refresh overhead. In the videos below, LVGL changes the color of any screen area that is being redrawn.

[philmoz]

So there will be a performance boost after this PR is applied?

Well the CPU will be doing less work refreshing stuff so there should be some improvement.
How much is hard to determine - there are some pages that take a while to build; but this is LVGL overhead so they don't change.

On my TX16S this PR feels more responsive overall; but that could be my imagination :)

[XuNeo]

Hi @philmoz ,

Lua widgets still redraw every 100ms (or so) - we really need a better display API for Lua apps.

I have developed a lua lvgl binding. It's not 100% finished yet, but I would love to hear from your input to make it better.

The binding will be upgraded to lvgl v9 soon, which has been improved a bit for bindings using the new property APIs.

[philmoz]

I have developed a lua lvgl binding. It's not 100% finished yet, but I would love to hear from your input to make it better.

The binding will be upgraded to lvgl v9 soon, which has been improved a bit for bindings using the new property APIs.

Thanks, it is on my radar to look all - does it support lvgl 8.2?

[XuNeo]

I have just pushed a fix to make it compatible with v8.2. Not fully tested but the basic function can work now.

[3DRacer]

My RM TX16S with DE language freezes when trying to display the SD card contents. Key SYS--> Open SD card directory. Only by removing the battery can it be revived. Is this known?

[philmoz]

My RM TX16S with DE language freezes when trying to display the SD card contents. Key SYS--> Open SD card directory. Only by removing the battery can it be revived. Is this known?

Are you using the latest version of this PR?
Does it happen with the current nightly version?
Can you try a different SD card?

[3DRacer]

My RM TX16S with DE language freezes when trying to display the SD card contents. Key SYS--> Open SD card directory. Only by removing the battery can it be revived. Is this known?

Are you using the latest version of this PR? Does it happen with the current nightly version? Can you try a different SD card?

• yes, that is the version from January 4th. Same problem with previous versions of this PR
• SD content view is fine with latest nightly fa12b27
• My SD is a sandisk16GB, formatted in 4GB with 4KB cluster
• With another SD 16GB with FAT32 standard formatting the channel also freezes

Note: The problem occurs with several themes. With the edgetx standard themes (tested with blue) the display of the SD card content works perfectly.

[offer-shmuely]

can the "title scroll up" be part of this changes?
as describe in #3667

[philmoz]

can the "title scroll up" be part of this changes? as describe in #3667

Not planned (by me) at this stage. I have not looked at it closely enough yet to say how feasible it will be.

[pfeerick]

When editing screen layouts the selected widget has the solid border and the others have a dashed border:

When you first go in, the first box has both dotted and solid border.

Topbar battery icon shows battery level as a colored bar - green >= 60%, amber 25% - 59%, red < 25% (these are LVGL, not theme colors):

I do like this for the the default theme, but I wonder if it will become a problem for other themes... ie.. when the top bar is red or green...

I also like how there is now a "dimming" for disabled controls, and also when you touch/ENTER on controls (i.e. giving feedback).

In Model Setup, the fields for the model image and name are shorter... the former isn't such an issue, but the latter should be longer so you can see more of the name.

Other visual changes look fine. Performance wise, having just come from 2.10-rc2, this actually feels more sluggish.
Also, when you are in the channel monitor, you can actually see the channel bars and text rebuilt, whereas 2.10 has no delay/artifacts.

[philmoz]

When editing screen layouts the selected widget has the solid border and the others have a dashed border:
When you first go in, the first box has both dotted and solid border.

Thanks, may have lost something in one of the rebases. Will look into it.

In Model Setup, the fields for the model image and name are shorter... the former isn't such an issue, but the latter should be longer so you can see more of the name.

The boxes should resize to fit the name - they do on my TX16S.

Performance wise, having just come from 2.10-rc2, this actually feels more sluggish. Also, when you are in the channel monitor, you can actually see the channel bars and text rebuilt, whereas 2.10 has no delay/artifacts.

Which radio?
The channel monitor has no issues on my TX16S, and overall performance does not seem slower to me.
Can you record a video of the channel monitor.
I did timing tests between 2.9 and this PR a while ago but have not done any recently - they were pretty similar across the board.

[pfeerick]

TX16S. you'll see on the radio on the left the lag and also the shorter than model name field.

Video may still be unavailable for a few minutes as was still running through copyright checks... https://youtu.be/gg5X17oLii8

[philmoz]

I've fixed the channel monitor and the model name field size plus made a few performance improvements.
I still have to do some work on the Mixes and Outputs pages as they are slightly slower than 2.10; but the rest of the UI should perform similarly to 2.10 as far as I can tell.

[pfeerick]

Much better... it's still a little more sluggish than 2.10 but much better than it was. Did you want to work on this more or merge and keep going? One less PR to rebase ;)

[philmoz]

Much better... it's still a little more sluggish than 2.10 but much better than it was. Did you want to work on this more or merge and keep going? One less PR to rebase ;)

If you're ready to go with big 2.11 changes then I'd like to get this in.

[pfeerick]

Your wish is granted. I'm crossing fingers 2.10 won't be needing any major changes by this point in the RC cycle so cherrypicking anything needed for it not too... painful?