chore(cpn): move model edit setup classes to own code files #5678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elecpower
added
companion
elecpower
force-pushed
the
elecpower/cpn-split-modeledit-settings
branch
from
48b79f8 to
c88a4b8
Compare
|
@pfeerick I'll rebase this one |
|
Thanks Neil... was going to look at it this afternoon to see if was easily
doable or better left to you ;)
…---------- Forwarded message ---------
From: Neil Horne ***@***.***>
Date: Sat, 23 Nov 2024, 10:31 am
Subject: Re: [EdgeTX/edgetx] chore(cpn): move model edit setup classes to
own code files (PR #5678)
To: EdgeTX/edgetx ***@***.***>
Cc: Peter Feerick ***@***.***>, Mention <
***@***.***>
@pfeerick <https://github.com/pfeerick> I'll rebase this one
—
Reply to this email directly, view it on GitHub
<#5678 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABJ66KNYSCT3LDK3NQCPGKD2B7EF7AVCNFSM6AAAAABSEM2YEWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJVGE2DOOBTGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
elecpower
force-pushed
the
elecpower/cpn-split-modeledit-settings
branch
from
c88a4b8 to
f253f04
Compare
pfeerick
approved these changes
Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Model edit setup has become monolithic so separate classes into separate code files: