Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new change to have multiple mask values #137

Merged
merged 3 commits into from
Jun 5, 2024

Conversation

dngoldberg
Copy link
Collaborator

@dngoldberg dngoldberg commented May 26, 2024

this builds on PR 133 which has now been merged.

according to 133, a mask is provided which is either zero or larger than zero.

this new functionality allows a mask with multiple (positive) integer values, and a run only calculates VAF where the mask is equal to a given integer code.

the code is set via "qoi_vaf_mask_code" (integer, default 1)
and if "qoi_vaf_mask_usecode" is True, this functionality is used -- otherwise the default functionality, that VAF is calculated where the mask if positive.

the appropriate section of the toml file will be as follows:

[io]
..
vaf_mask_data_file = ...  # variable in netcdf file needs name "vaf_mask"

..

[errorprop]

qoi = 'vaf'
phase_suffix = ...
qoi_apply_vaf_mask = true       # this should be set to true to enable masking
qoi_vaf_mask_usecode = true  # if set to true, then VAF is calculated only in region of vaf_mask_data_file 
                             # where vaf_mask is equal to qoi_vaf_mask_code
                             # if set to false (default), then VAF is calculated in region of 
                             # vaf_mask_data_file where vaf_mask > 0
qoi_vaf_mask_code = 3       

@dngoldberg dngoldberg marked this pull request as draft May 26, 2024 14:51
@dngoldberg dngoldberg requested a review from jrmaddison May 27, 2024 12:52
@dngoldberg dngoldberg self-assigned this May 27, 2024
@dngoldberg dngoldberg marked this pull request as ready for review May 27, 2024 12:53
@dngoldberg dngoldberg merged commit c2ea8b9 into EdiGlacUQ:main Jun 5, 2024
1 check passed
@dngoldberg dngoldberg deleted the branch_vaf_mask_multiple branch June 5, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant