Skip to content

Commit

Permalink
add appId to Telemetry (facebook#47099)
Browse files Browse the repository at this point in the history
Summary:

Changelog: [Internal]

As discussed in D64547367, recent changes caused `description` to stop reporting `appId`.

This impacted Telemetry's "top apps" dashboards.
{F1936011487}

Reviewed By: hoxyq

Differential Revision: D64548348
  • Loading branch information
EdmondChuiHW authored and facebook-github-bot committed Oct 17, 2024
1 parent d992d40 commit 8c8d54d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,7 @@ export default function openDebuggerMiddleware({
appId: appId ?? null,
deviceId: device ?? null,
resolvedTargetDescription: target.description,
resolvedTargetAppId: target.appId,
prefersFuseboxFrontend: useFuseboxEntryPoint ?? false,
});
return;
Expand Down
1 change: 1 addition & 0 deletions packages/dev-middleware/src/types/EventReporter.js
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ export type ReportableEvent =
appId: string | null,
deviceId: string | null,
resolvedTargetDescription: string,
resolvedTargetAppId: string,
prefersFuseboxFrontend: boolean,
}>
| ErrorResult<mixed>
Expand Down

0 comments on commit 8c8d54d

Please sign in to comment.