Skip to content

Commit

Permalink
fix(android): prevent breaking builds for react native 0.57
Browse files Browse the repository at this point in the history
The android package 'io.intercom.android:intercom-sdk-base' version 5.1.6 introduced a breaking change.. (Come on people! Learn semantic versioning). More specifically it uses version 28 of com.android.support:appcompat-v7. This causes a problem for people using react native 0.57, because it uses version 27. So we lock down intercom-sdk-base to version 5.1.5 to stay on version 27 of com.android.support:appcompat-v7.
  • Loading branch information
sondremare committed Nov 15, 2018
1 parent cd44874 commit 563a9af
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,6 @@ repositories {

dependencies {
compile 'com.facebook.react:react-native:+'
compile 'io.intercom.android:intercom-sdk-base:5.+'
compile 'io.intercom.android:intercom-sdk-base:5.1.5'
}

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "react-native-intercom",
"version": "12.2.0",
"version": "12.2.0-1",
"description": "A React Native client for Intercom.io",
"main": "./lib/IntercomClient.js",
"scripts": {
Expand Down

0 comments on commit 563a9af

Please sign in to comment.