Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Notification.php #30

Closed
wants to merge 1 commit into from
Closed

Update Notification.php #30

wants to merge 1 commit into from

Conversation

rayansys
Copy link

@rayansys rayansys commented Aug 3, 2020

add android_channel_id

add android_channel_id
@coveralls
Copy link

coveralls commented Aug 3, 2020

Pull Request Test Coverage Report for Build 679

  • 2 of 5 (40.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.6%) to 97.326%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Push/Notification.php 2 5 40.0%
Totals Coverage Status
Change from base Build 673: -1.6%
Covered Lines: 182
Relevant Lines: 187

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 679

  • 2 of 5 (40.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.6%) to 97.326%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Push/Notification.php 2 5 40.0%
Totals Coverage Status
Change from base Build 673: -1.6%
Covered Lines: 182
Relevant Lines: 187

💛 - Coveralls

@AndyGaskell
Copy link
Collaborator

There is discussion re this on...
Android Notification channel id #29

@rolinger
Copy link
Collaborator

rolinger commented Sep 5, 2024

@rayansys - it looks like your changes are in conflict. Can you please resolve?

While adding for the android_id it seems you deleted code for $click_action and $image_url

@rolinger
Copy link
Collaborator

rolinger commented Sep 5, 2024

This has been merged from a patch branch https://github.com/EdwinHoksberg/php-fcm/tree/rayansys-patch-1

@rolinger
Copy link
Collaborator

rolinger commented Sep 5, 2024

closing.

@rolinger rolinger closed this Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants