Some simplifications and code polish #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`then` and `minimaly` were misspelled, I'm replacing with simpler / more standard wording.
This fixes the `catch` clause in the `send()` function, so the user-visible behavior changes in that `FcmClientException` is now thrown instead.
As discussed on EdwinHoksberg#48. This is a user-visible breaking API change, though most users probably won't care, as they use FcmClient::send() instead. Also document the NotificationException thrown from there, which existed before but just wasn't documented (not a breaking change).
`current()` is broken when someone else previously fiddled with iterators on the passed array. `[0]` is guaranteed to work if the array has numerical indices, which can be enforced by using `array_values()` in `addRecipient()`. Also reject invalid inputs there instead of silently dropping them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the individual commit messages and diffs.
Breaking changes:
ext-jsonis now declared as a dependency. It was actually a dependency before, but now it's declared, which might break some builds.Request::getBody()was renamed toRequest::buildJsonBody(). Most clients won't care, as they don't call this function.FcmClient::send()does not throwGuzzleExceptionanymore, but now wraps it intoFcmClientException(same exception type as when the server returns an error).