Arbitrary: fix bug related to refinements of declarations raising a w… (

#4137)

.changeset/little-baboons-count.md

@@ -0,0 +1,5 @@
+---
+"effect": patch
+---
+
+Arbitrary: fix bug where refinements in declarations raised an incorrect missing annotation error, closes #4136

packages/effect/src/Arbitrary.ts

@@ -268,6 +268,9 @@ const go = (
         return hook.value(ctx)
     }
   }
+  if (AST.isDeclaration(ast)) {
+    throw new Error(errors_.getArbitraryMissingAnnotationErrorMessage(path, ast))
+  }
   const op = toOp(ast, ctx, path)
   switch (op._tag) {
     case "Succeed":
@@ -289,7 +292,7 @@ export const toOp = (
 ): Op => {
   switch (ast._tag) {
     case "Declaration":
-      throw new Error(errors_.getArbitraryMissingAnnotationErrorMessage(path, ast))
+      return new Succeed(go(ast, ctx, path))
     case "Literal":
       return new Succeed((fc) => fc.constant(ast.literal))
     case "UniqueSymbol":

packages/effect/src/Schema.ts

@@ -6233,8 +6233,8 @@ export class DateFromSelf extends declare(
   {
     identifier: "DateFromSelf",
     description: "a potentially invalid Date instance",
-    pretty: (): pretty_.Pretty<Date> => (date) => `new Date(${JSON.stringify(date)})`,
-    arbitrary: (): LazyArbitrary<Date> => (fc) => fc.date({ noInvalidDate: false }),
+    pretty: () => (date) => `new Date(${JSON.stringify(date)})`,
+    arbitrary: () => (fc) => fc.date({ noInvalidDate: false }),
     equivalence: () => Equivalence.Date
   }
 ) {}

packages/effect/test/Schema/Arbitrary/Arbitrary.test.ts

@@ -521,6 +521,13 @@ details: Generating an Arbitrary for this schema requires at least one enum`)
   })
 
   describe("Refinement", () => {
+    describe("declaration filters", () => {
+      it("ValidDateFromSelf", () => {
+        const schema = S.ValidDateFromSelf
+        expectValidArbitrary(schema)
+      })
+    })
+
     describe("array filters", () => {
       it("minItems", () => {
         const schema = S.Array(S.String).pipe(S.minItems(2))