[bugfix] concurrentFinalizers in Effect.all implementation (#4194)

Effect-TS · Dec 26, 2024 · 302b57d · 302b57d
1 parent 16dd657
commit 302b57d
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 4 deletions.
diff --git a/.changeset/brave-eagles-lay.md b/.changeset/brave-eagles-lay.md
@@ -0,0 +1,5 @@
+---
+"effect": patch
+---
+
+take concurrentFinalizers option in account in `Effect.all` combinator
diff --git a/packages/effect/src/internal/fiberRuntime.ts b/packages/effect/src/internal/fiberRuntime.ts
@@ -1847,7 +1847,8 @@ const allValidate = (
   return core.flatMap(
     forEach(eitherEffects, identity, {
       concurrency: options?.concurrency,
-      batching: options?.batching
+      batching: options?.batching,
+      concurrentFinalizers: options?.concurrentFinalizers
     }),
     (eithers) => {
       const none = Option.none()
@@ -1899,14 +1900,16 @@ const allEither = (
     return forEach(eitherEffects, identity, {
       concurrency: options?.concurrency,
       batching: options?.batching,
-      discard: true
+      discard: true,
+      concurrentFinalizers: options?.concurrentFinalizers
     })
   }
 
   return core.map(
     forEach(eitherEffects, identity, {
       concurrency: options?.concurrency,
-      batching: options?.batching
+      batching: options?.batching,
+      concurrentFinalizers: options?.concurrentFinalizers
     }),
     (eithers) =>
       reconcile._tag === "Some" ?
@@ -2579,7 +2582,8 @@ export const validateAll = dual<
     core.flatMap(
       partition(elements, f, {
         concurrency: options?.concurrency,
-        batching: options?.batching
+        batching: options?.batching,
+        concurrentFinalizers: options?.concurrentFinalizers
       }),
       ([es, bs]) =>
         es.length === 0