Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve: Enhance pretty cause #3853

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

improve: Enhance pretty cause #3853

wants to merge 7 commits into from

Conversation

patroza
Copy link
Member

@patroza patroza commented Oct 28, 2024

No description provided.

@patroza patroza requested a review from mikearnaldi as a code owner October 28, 2024 13:54
Copy link

changeset-bot bot commented Oct 28, 2024

🦋 Changeset detected

Latest commit: 6888351

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 34 packages
Name Type
effect Patch
@effect/cli Patch
@effect/cluster-browser Patch
@effect/cluster-node Patch
@effect/cluster-workflow Patch
@effect/cluster Patch
@effect/experimental Patch
@effect/opentelemetry Patch
@effect/platform-browser Patch
@effect/platform-bun Patch
@effect/platform-node-shared Patch
@effect/platform-node Patch
@effect/platform Patch
@effect/printer-ansi Patch
@effect/printer Patch
@effect/rpc-http Patch
@effect/rpc Patch
@effect/sql-clickhouse Patch
@effect/sql-d1 Patch
@effect/sql-drizzle Patch
@effect/sql-kysely Patch
@effect/sql-libsql Patch
@effect/sql-mssql Patch
@effect/sql-mysql2 Patch
@effect/sql-pg Patch
@effect/sql-sqlite-bun Patch
@effect/sql-sqlite-node Patch
@effect/sql-sqlite-react-native Patch
@effect/sql-sqlite-wasm Patch
@effect/sql Patch
@effect/typeclass Patch
@effect/vitest Patch
@effect/ai Patch
@effect/ai-openai Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@patroza patroza requested a review from tim-smart October 28, 2024 14:00
return !cause && !!Object.keys(rest).length ?
stack :
`${stack} {${json.substring(1, json.length - 1).split("\n").join("\n").trimEnd()}${
cause ? ",\n" + renderErrorCause(cause as PrettyError, " ") : ""
Copy link
Contributor

@tim-smart tim-smart Nov 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to move this logic to renderErrorCause to support nested errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Discussion Ongoing
Development

Successfully merging this pull request may close these issues.

2 participants