Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of hrtime in Duration.decode #4341

Merged
merged 4 commits into from
Jan 30, 2025
Merged

Fix handling of hrtime in Duration.decode #4341

merged 4 commits into from
Jan 30, 2025

Conversation

fubhy
Copy link
Member

@fubhy fubhy commented Jan 25, 2025

No description provided.

@fubhy fubhy requested a review from mikearnaldi as a code owner January 25, 2025 17:35
@fubhy fubhy requested review from gcanti and removed request for mikearnaldi January 25, 2025 17:35
Copy link

changeset-bot bot commented Jan 25, 2025

🦋 Changeset detected

Latest commit: 15c6274

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
effect Patch
@effect/cli Patch
@effect/cluster-browser Patch
@effect/cluster-node Patch
@effect/cluster-workflow Patch
@effect/cluster Patch
@effect/experimental Patch
@effect/opentelemetry Patch
@effect/platform-browser Patch
@effect/platform-bun Patch
@effect/platform-node-shared Patch
@effect/platform-node Patch
@effect/platform Patch
@effect/printer-ansi Patch
@effect/printer Patch
@effect/rpc-http Patch
@effect/rpc Patch
@effect/sql-clickhouse Patch
@effect/sql-d1 Patch
@effect/sql-drizzle Patch
@effect/sql-kysely Patch
@effect/sql-libsql Patch
@effect/sql-mssql Patch
@effect/sql-mysql2 Patch
@effect/sql-pg Patch
@effect/sql-sqlite-bun Patch
@effect/sql-sqlite-do Patch
@effect/sql-sqlite-node Patch
@effect/sql-sqlite-react-native Patch
@effect/sql-sqlite-wasm Patch
@effect/sql Patch
@effect/typeclass Patch
@effect/vitest Patch
@effect/ai Patch
@effect/ai-openai Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@fubhy fubhy closed this Jan 25, 2025
@fubhy fubhy deleted the fix-duration-input branch January 25, 2025 19:54
@fubhy fubhy restored the fix-duration-input branch January 26, 2025 11:55
@fubhy fubhy reopened this Jan 26, 2025
@fubhy fubhy force-pushed the fix-duration-input branch 5 times, most recently from c70ade0 to 1ab9db2 Compare January 27, 2025 09:53
@fubhy fubhy changed the title remove tuple representation from DurationInput Fix handling of hrtime in Duration.decode Jan 28, 2025
packages/effect/test/Duration.test.ts Outdated Show resolved Hide resolved
@fubhy fubhy force-pushed the fix-duration-input branch from e55dfb2 to 7afc1d6 Compare January 30, 2025 13:47
@fubhy fubhy requested a review from gcanti January 30, 2025 13:48
packages/effect/test/Duration.test.ts Outdated Show resolved Hide resolved
packages/effect/test/Duration.test.ts Outdated Show resolved Hide resolved
@gcanti gcanti merged commit 766113c into main Jan 30, 2025
12 checks passed
@gcanti gcanti deleted the fix-duration-input branch January 30, 2025 15:55
@github-actions github-actions bot mentioned this pull request Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants