Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build warning for AccountSettingReducer #357

Merged
merged 5 commits into from
Jan 27, 2024
Merged

Fix build warning for AccountSettingReducer #357

merged 5 commits into from
Jan 27, 2024

Conversation

remlostime
Copy link
Contributor

@remlostime remlostime commented Nov 17, 2023 •
edited
Loading

#356

Fix a bunch of build warning in AccountSettingReducer
image

tatsuz0u
tatsuz0u reviewed Nov 27, 2023
View reviewed changes
Copy link
Contributor

@tatsuz0u tatsuz0u left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your commitment and the work you've put into this pull request! It's great to welcome a new committer to the repository. Now, onto some detailed feedback to help fine-tune your submission.

@remlostime
Copy link
Contributor Author

@tatsuz0u Thanks for the detailed comments! Could you take another look?

@remlostime remlostime requested a review from tatsuz0u December 1, 2023 01:17
@tatsuz0u
Copy link
Contributor

LGTM!

cc @chihchy

@chihchy chihchy merged commit cf491b2 into EhPanda-Team:main Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chihchy chihchy chihchy approved these changes

@tatsuz0u tatsuz0u Awaiting requested review from tatsuz0u

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@remlostime @tatsuz0u @chihchy