Loop: Correct loops over boundaries

Include the corners, exclude the interior.
EinsteinToolkit · Jul 23, 2024 · a8c262e · a8c262e
1 parent 0126ae0
commit a8c262e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/Loop/src/loop.hxx b/Loop/src/loop.hxx
@@ -345,7 +345,7 @@ public:
     domain_boxes<CI, CJ, CK>(group_nghostzones, all_min, all_max, int_min,
                              int_max);
 
-    for (int rank = dim - 1; rank >= 0; --rank) {
+    for (int rank = dim; rank > 0; --rank) {
 
       for (int nk = -1; nk <= +1; ++nk) {
         for (int nj = -1; nj <= +1; ++nj) {
@@ -401,7 +401,7 @@ public:
                         const F &f) const {
     constexpr vect<int, dim> offset{CI, CJ, CK};
 
-    for (int rank = dim - 1; rank >= 0; --rank) {
+    for (int rank = dim; rank > 0; --rank) {
 
       for (int nk = -1; nk <= +1; ++nk) {
         for (int nj = -1; nj <= +1; ++nj) {
@@ -485,7 +485,7 @@ public:
     domain_boxes<CI, CJ, CK>(group_nghostzones, all_min, all_max, int_min,
                              int_max);
 
-    for (int rank = dim - 1; rank >= 0; --rank) {
+    for (int rank = dim; rank > 0; --rank) {
 
       for (int nk = -1; nk <= +1; ++nk) {
         for (int nj = -1; nj <= +1; ++nj) {
@@ -584,7 +584,7 @@ public:
     // rank(face)     = 2
     // rank(edge)     = 1
     // rank(corner)   = 0
-    for (int rank = dim - 1; rank >= 0; --rank) {
+    for (int rank = dim; rank > 0; --rank) {
 
       // Nested loops that determine {ni,nj,nk} components of the normal vector
       for (int nk = -1; nk <= +1; ++nk) {

diff --git a/Loop/src/loop_device.hxx b/Loop/src/loop_device.hxx
@@ -216,7 +216,7 @@ public:
     domain_boxes<CI, CJ, CK>(group_nghostzones, all_min, all_max, int_min,
                              int_max);
 
-    for (int rank = dim - 1; rank >= 0; --rank) {
+    for (int rank = dim; rank > 0; --rank) {
 
       for (int nk = -1; nk <= +1; ++nk) {
         for (int nj = -1; nj <= +1; ++nj) {
@@ -318,7 +318,7 @@ public:
     // rank(face)     = 2
     // rank(edge)     = 1
     // rank(corner)   = 0
-    for (int rank = dim - 1; rank >= 0; --rank) {
+    for (int rank = dim; rank > 0; --rank) {
 
       // Nested loops that determine {ni,nj,nk} components of the normal vector
       for (int nk = -1; nk <= +1; ++nk) {
@@ -381,7 +381,7 @@ public:
                                const F &f) const {
     constexpr vect<int, dim> offset{CI, CJ, CK};
 
-    for (int rank = dim - 1; rank >= 0; --rank) {
+    for (int rank = dim; rank > 0; --rank) {
 
       for (int nk = -1; nk <= +1; ++nk) {
         for (int nj = -1; nj <= +1; ++nj) {
@@ -447,7 +447,7 @@ public:
     domain_boxes<CI, CJ, CK>(group_nghostzones, all_min, all_max, int_min,
                              int_max);
 
-    for (int rank = dim - 1; rank >= 0; --rank) {
+    for (int rank = dim; rank > 0; --rank) {
 
       for (int nk = -1; nk <= +1; ++nk) {
         for (int nj = -1; nj <= +1; ++nj) {