-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Derivs: Use GF3D2 as input in calc_derivs #180
Conversation
layout.delta(1, 0, 0), | ||
layout.delta(0, 1, 0), | ||
layout.delta(0, 0, 1), | ||
gf.delta(1, 0, 0), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think these lines are correct. I don't think that the grid function class GF3D2
has a delta
member function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checkout line 946
of loop.hxx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added comments requesting changes.
Hi @eschnett , I have addressed your comments. please take a look again. Thanks |
No description provided.