Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ODESolvers: Solve only in the interior #301

Merged
merged 13 commits into from
Aug 1, 2024
Merged

ODESolvers: Solve only in the interior #301

merged 13 commits into from
Aug 1, 2024

Conversation

eschnett
Copy link
Collaborator

No description provided.

@lwJi
Copy link
Contributor

lwJi commented Jul 31, 2024 •
edited
Loading

It breaks unit tests in WaveToyX and TestODESolves

  1. WaveToyX: this one can be fixed if we schedule a WaveToyX_Sync in ODESolvers_PostStep,
  2. TestODESolves: this one might just because it's not using the loop macros. We might just remove this one from thornlist, because we have another equivalent one called TestODESolves2 which uses loop macros.

@rhaas80 rhaas80 merged commit 309a2c8 into main Aug 1, 2024
20 checks passed
@eschnett eschnett deleted the eschnett/odesolver-interior branch August 2, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhaas80 rhaas80 rhaas80 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eschnett @lwJi @rhaas80