-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend 'Derivs' to cover 6th and 8th order finite difference #307
Conversation
Fails in SYCL build due to calls via function pointer: needs changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fails due to compile for SYCL due to calls via function pointer:
probably also would fail (at runtime) for CUDA.
I have remove the usage of function pointer, please take another look |
Hi @rhaas80, I think I have addressed all your comments in the recent few commits. please take another look. Thanks |
Formatting change requested. Looks ok otherwise. |
@rhaas80 Just pushed the formatting change. Thanks for catching it |
Thank you. Looks good to me. You may want to reduce the (large) number of commits using a round of |
@rhaas80 , good point. I have squash them into 3 comments. |
Derivs
:TestDerivs
:all the coefficients used are calculated here using mathematica
https://github.com/lwJi/Docs-Subcycling/blob/main/wolfram/Derivs.ipynb