CarpetX: Add interpolator self-checks #326
Conversation
|
This mostly improves error messages (when built with |
| CCTK_VINFO("patch %d level %d component %d old_nparticles: %zu", | ||
| patch, lev, component, particles.size()); | ||
| // CCTK_VINFO("patch %d level %d component %d old_nparticles: %zu", | ||
| // patch, lev, component, particles.size()); |
There was a problem hiding this comment.
I'd remove or move behind a #ifdef DEBUG this code.
| CCTK_VINFO("patch %d level %d component %d new_nparticles: %zu", | ||
| patch, lev, component, particles.size()); | ||
| // CCTK_VINFO("patch %d level %d component %d new_nparticles: %zu", | ||
| // patch, lev, component, particles.size()); |
There was a problem hiding this comment.
I'd remove or move behind a #ifdef DEBUG this code.
There was a problem hiding this comment.
(also similar in line 611ff below)
| @@ -850,6 +889,7 @@ extern "C" void CarpetX_Interpolate(const CCTK_POINTER_TO_CONST cctkGH_, | |||
| // Set result | |||
| CCTK_REAL *const restrict *const restrict resultptrs = | |||
| static_cast<CCTK_REAL *const *>(resultptrs_); | |||
| assert(int(recvbuf.size()) == (nvars + 1) * npoints); | |||
There was a problem hiding this comment.
assert is too late the code in CCTK_DEBUG in line 876 alreay touches all points.
There was a problem hiding this comment.
This assert can trigger if there are points outside of the domain, can't it?
In that case this assert does not adhere to the API set out in the ReferenceManual for CCTK InterpGridArrays which documents CCTK ERROR INTERP POINT OUTSIDE as a possible return value and does not indicate that the code would abort.
No description provided.