Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Arduino diagram #249

Merged

Conversation

JesusSilvaUtrera
Copy link
Contributor

🎉 New feature

Part of #239

Summary

This PR is just to add the new diagram for the Arduino Nano, motors and IMU with the changes from the firmware, in order to delete the warning on the README.md in andino_hardware package.

Just FYI @jballoffet: I didn't replace the 5V and GND for their electric symbols becuase when I tried it, the symbols had to be really small and I think at the end the diagram became less clear.

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: JesusSilvaUtrera <[email protected]>
Copy link
Member

@jballoffet jballoffet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JesusSilvaUtrera! I left some comments, PTAL.

Copy link
Collaborator

@francocipollone francocipollone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, this is super useful.
+1 to Javi's comments.

I wonder if it makes sense to also integrate here the stepup regulator.

@JesusSilvaUtrera
Copy link
Contributor Author

I wonder if it makes sense to also integrate here the stepup regulator.

I was thinking of doing 3 diagrams: this one for the arduino, another one for the Raspberry Pi and the final one for the power, so the stepup would be placed there.

Copy link
Member

@jballoffet jballoffet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JesusSilvaUtrera! Left some comments, PTAL.

Copy link
Member

@jballoffet jballoffet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @JesusSilvaUtrera!

@jballoffet jballoffet merged commit 3d4baa6 into Ekumen-OS:humble May 16, 2024
4 checks passed
@JesusSilvaUtrera JesusSilvaUtrera deleted the jesus/add_new_arduino_diagram branch May 27, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants