Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added function to replace color definitions #22

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Conversation

IDavGal
Copy link
Collaborator

@IDavGal IDavGal commented Sep 22, 2023

Adds a function that maps the color declaration by name with a definition of the color in each case. This is due to urdf2webots not parsing the rViz color definitions properly.
A comment is placed to keep track of this hotfix until the issue is resolved in the main package.

An issue for this was created in the urdf2webots repository: #210

CC @BarceloChristian

@IDavGal IDavGal self-assigned this Sep 22, 2023
Copy link
Collaborator

@francocipollone francocipollone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@IDavGal IDavGal merged commit 8bb691d into main Sep 22, 2023
@IDavGal IDavGal deleted the igallesio/fix_colors branch September 22, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants