Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Wagas #178

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

add Wagas #178

wants to merge 6 commits into from

Conversation

ma125125t
Copy link

No description provided.

@xhacker
Copy link
Member

xhacker commented Sep 24, 2020

Hi @fffang, thanks for the contribution! Can you put the new cafe at the bottom of the file instead of at the top?

@ma125125t
Copy link
Author

@xhacker updated

shanghai.geojson Outdated Show resolved Hide resolved
Copy link
Author

@ma125125t ma125125t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix reslove JSON error

@ma125125t
Copy link
Author

should be all right now @xavierchow

@xavierchow
Copy link
Collaborator

ah, CI failed as the 下载速度 is missing, @fffang do you have a way to record the wifi speed for this cafe in your PR?
cc @xhacker is it a mandatory field for a PR?

@xhacker
Copy link
Member

xhacker commented Sep 30, 2020

@xavierchow yeah, it’s currently mandatory. @fffang are you able to record the Wi-Fi speed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants