Improve benchmark measures #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elanis
force-pushed
the
improve-benchmark
branch
from
e53462d
to
23c50ae
Compare
This was
linked to
issues
Feb 8, 2023
Elanis
force-pushed
the
improve-benchmark
branch
5 times, most recently
from
ff15574
to
bcecdc0
Compare
|
Results aren't really convincing :/ Difference between free memory before/during run are lower than main process consumption ... I might need to try alternative way to measure system-wide used memory (maybe considering swap ?) |
|
Here are the current results, they are not THAT bad on some, but something looks off for others.
|
Elanis
force-pushed
the
improve-benchmark
branch
from
a8d4f7b
to
e2f704a
Compare
Elanis
force-pushed
the
main
branch
2 times, most recently
from
c93e0f0
to
6c04567
Compare
Elanis
force-pushed
the
improve-benchmark
branch
2 times, most recently
from
411cf70
to
188ef7f
Compare
|
That's a bit better, but still a bit off |
NodeGUI/qode now support it: https://github.com/nodegui/nodegui/releases/tag/v0.58.0
Elanis
force-pushed
the
improve-benchmark
branch
from
73e5b7c
to
7f30e7b
Compare
|
There might be a difference of what is measured, but now we get relevent measures which looks okay: Let's wait for all OSes to run and compare both benchmarks. Could be a good milestone for merging 😄 |
…ss without issues
Elanis
force-pushed
the
improve-benchmark
branch
from
2c9e425
to
9468bca
Compare
|
My issue with process not terminating on Windows looks fixed, waiting for all results, but I believe I can merge this today 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.