-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace restaurants with food options and update components styles #7
base: main
Are you sure you want to change the base?
Conversation
ameliedefrance
commented
Apr 16, 2024
•
edited
Loading
edited
![Screenshot 2024-04-16 at 16 06 42](https://private-user-images.githubusercontent.com/25897625/322898353-5921b82d-0ca2-4580-a220-7621745b48af.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjM5NzQwMjcsIm5iZiI6MTcyMzk3MzcyNywicGF0aCI6Ii8yNTg5NzYyNS8zMjI4OTgzNTMtNTkyMWI4MmQtMGNhMi00NTgwLWEyMjAtNzYyMTc0NWI0OGFmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODE4VDA5MzUyN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWUxNTZiNDBmNmMyYTIxMDM2OWIwNDJlZmM4Y2NjYjE4ODZmMGI5ZmZmZWFlZGVjNzc2Yzk2OWJmNzU5NTlkYjYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.qVz1_vS8MTUNdgnhw9upFsD_Z8nJXs8WMLDRSFjJte4)
- Replace restaurants with food options
- Rename components
- Update theme & components styling
4a75272
to
b1dde0f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great 👍
@@ -1,20 +1,17 @@ | |||
import '@assets/app.scss' | |||
import AppLayout from '@app/layouts/AppLayout.tsx'; | |||
import AppLayout from '@app/layouts/app-layout.tsx'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C'est une nouvelle pratique d'ajouter des tirets et retirer les majuscules ? :o Je découvre
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah bah alors aucune idée, c'est comme ça sur Rigby et je sais pas si ça vient de nos pratiques ou des leurs ! Là bas les noms de fichiers sont en kebab case et les composants en pascal case, j'ai fait pareil 🙈
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
J'invoque @ogizanagi 🧞
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah non, ce sont des pratiques propres à Rigby (une préférence de Guillaume par rapport à des soucis de casse sur Windows qu'il a pu rencontrer). On s'est alignés sur le projet, mais je suis pour conserver du PascalCase pour les composants et leurs noms de fichier chez nous 😃
(le kebab-case peut-être conservé mais plutôt pour des dossiers, pas des fichiers)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Team Pascal et pas kebab, c'est noté 🌮
|
||
// TODO: Unused component, keep for future version ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oui, au cas où... M'enfin ça partira dans l'été si on n'en a pas l'utilité 👍