[#270] Audit issue C: Properly check read()

Electric-Coin-Company · Apr 14, 2024 · fb9233c · fb9233c
1 parent 26094e2
commit fb9233c
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/bip39-lib/src/unixMain/kotlin/cash/z/ecc/android/random/SecureRandom.kt b/bip39-lib/src/unixMain/kotlin/cash/z/ecc/android/random/SecureRandom.kt
@@ -26,7 +26,9 @@ actual class SecureRandom {
                     bytes.usePinned {
                         read(randomData, it.addressOf(0), bytes.size.convert())
                     }
-                check(result >= 0) {
+                // Warning: Operator '==' cannot be applied to 'ssize_t /* = Long */' and 'Int'
+                // Converting both sides to Long to ensure they fit in the range
+                check(result.toLong() == bytes.size.toLong()) {
                     "Could not get random number from /dev/urandom"
                 }
             }