Static code analysis warnings

Electric-Coin-Company · Aug 12, 2024 · c8563fd · c8563fd
1 parent 8e29eb0
commit c8563fd
Show file tree

Hide file tree

Showing 6 changed files with 30 additions and 16 deletions.
diff --git a/backend-lib/src/main/java/cash/z/ecc/android/sdk/internal/Backend.kt b/backend-lib/src/main/java/cash/z/ecc/android/sdk/internal/Backend.kt
@@ -43,7 +43,10 @@ interface Backend {
      * @throws RuntimeException as a common indicator of the operation failure
      */
     @Throws(RuntimeException::class)
-    suspend fun decryptAndStoreTransaction(tx: ByteArray, minedHeight: Long?)
+    suspend fun decryptAndStoreTransaction(
+        tx: ByteArray,
+        minedHeight: Long?
+    )
 
     /**
      * Sets up the internal structure of the data database.

diff --git a/backend-lib/src/main/java/cash/z/ecc/android/sdk/internal/jni/RustBackend.kt b/backend-lib/src/main/java/cash/z/ecc/android/sdk/internal/jni/RustBackend.kt
@@ -295,15 +295,17 @@ class RustBackend private constructor(
         }
     }
 
-    override suspend fun decryptAndStoreTransaction(tx: ByteArray, minedHeight: Long?) =
-        withContext(SdkDispatchers.DATABASE_IO) {
-            decryptAndStoreTransaction(
-                dataDbFile.absolutePath,
-                tx,
-                minedHeight = minedHeight ?: -1,
-                networkId = networkId
-            )
-        }
+    override suspend fun decryptAndStoreTransaction(
+        tx: ByteArray,
+        minedHeight: Long?
+    ) = withContext(SdkDispatchers.DATABASE_IO) {
+        decryptAndStoreTransaction(
+            dataDbFile.absolutePath,
+            tx,
+            minedHeight = minedHeight ?: -1,
+            networkId = networkId
+        )
+    }
 
     override suspend fun proposeTransfer(
         account: Int,

diff --git a/sdk-lib/src/androidTest/java/cash/z/ecc/fixture/FakeRustBackend.kt b/sdk-lib/src/androidTest/java/cash/z/ecc/fixture/FakeRustBackend.kt
@@ -104,8 +104,10 @@ internal class FakeRustBackend(
         TODO("Not yet implemented")
     }
 
-    override suspend fun decryptAndStoreTransaction(tx: ByteArray, minedHeight: Long?) =
-        error("Intentionally not implemented in mocked FakeRustBackend implementation.")
+    override suspend fun decryptAndStoreTransaction(
+        tx: ByteArray,
+        minedHeight: Long?
+    ) = error("Intentionally not implemented in mocked FakeRustBackend implementation.")
 
     override suspend fun initDataDb(seed: ByteArray?): Int =
         error("Intentionally not implemented in mocked FakeRustBackend implementation.")

diff --git a/sdk-lib/src/main/java/cash/z/ecc/android/sdk/block/processor/CompactBlockProcessor.kt b/sdk-lib/src/main/java/cash/z/ecc/android/sdk/block/processor/CompactBlockProcessor.kt
@@ -1951,8 +1951,9 @@ class CompactBlockProcessor internal constructor(
                 }
                 when (val response = downloader.fetchTransaction(rawTransactionId)) {
                     is Response.Success -> {
-                        val currentMinedHeight = runCatching { response.result.height.toBlockHeight(network) }
-                            .getOrNull()
+                        val currentMinedHeight =
+                            runCatching { response.result.height.toBlockHeight(network) }
+                                .getOrNull()
                         transactionDataResult = Pair(response.result.data, currentMinedHeight)
                     }
                     is Response.Failure -> {

diff --git a/sdk-lib/src/main/java/cash/z/ecc/android/sdk/internal/TypesafeBackend.kt b/sdk-lib/src/main/java/cash/z/ecc/android/sdk/internal/TypesafeBackend.kt
@@ -149,7 +149,10 @@ internal interface TypesafeBackend {
     @Throws(RuntimeException::class)
     suspend fun suggestScanRanges(): List<ScanRange>
 
-    suspend fun decryptAndStoreTransaction(tx: ByteArray, minedHeight: BlockHeight?)
+    suspend fun decryptAndStoreTransaction(
+        tx: ByteArray,
+        minedHeight: BlockHeight?
+    )
 
     fun getSaplingReceiver(ua: String): String?
 

diff --git a/sdk-lib/src/main/java/cash/z/ecc/android/sdk/internal/TypesafeBackendImpl.kt b/sdk-lib/src/main/java/cash/z/ecc/android/sdk/internal/TypesafeBackendImpl.kt
@@ -244,7 +244,10 @@ internal class TypesafeBackendImpl(private val backend: Backend) : TypesafeBacke
             )
         }
 
-    override suspend fun decryptAndStoreTransaction(tx: ByteArray, minedHeight: BlockHeight?) = backend
+    override suspend fun decryptAndStoreTransaction(
+        tx: ByteArray,
+        minedHeight: BlockHeight?
+    ) = backend
         .decryptAndStoreTransaction(tx, minedHeight?.value)
 
     override fun getSaplingReceiver(ua: String): String? = backend.getSaplingReceiver(ua)