Fix Detekt warning

Electric-Coin-Company · Sep 4, 2023 · dddd22e · dddd22e
1 parent 0a7620b
commit dddd22e
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 1 deletion.
diff --git a/demo-app/build.gradle.kts b/demo-app/build.gradle.kts
@@ -137,6 +137,7 @@ dependencies {
 
     implementation(libs.bundles.grpc)
     implementation(libs.kotlinx.datetime)
+    implementation(libs.kotlinx.immutable)
 }
 
 fladle {

diff --git a/.../main/java/cash/z/ecc/android/sdk/demoapp/ui/screen/transactions/view/TransactionsView.kt b/.../main/java/cash/z/ecc/android/sdk/demoapp/ui/screen/transactions/view/TransactionsView.kt
@@ -31,6 +31,8 @@ import cash.z.ecc.android.sdk.demoapp.R
 import cash.z.ecc.android.sdk.internal.Twig
 import cash.z.ecc.android.sdk.model.TransactionOverview
 import cash.z.ecc.android.sdk.model.WalletAddresses
+import kotlinx.collections.immutable.ImmutableList
+import kotlinx.collections.immutable.toPersistentList
 import kotlinx.coroutines.flow.flow
 import kotlinx.coroutines.flow.toList
 import kotlinx.coroutines.launch
@@ -72,6 +74,7 @@ fun Transactions(
                 paddingValues = paddingValues,
                 synchronizer,
                 synchronizer.transactions.collectAsStateWithLifecycle(initialValue = emptyList()).value
+                    .toPersistentList()
             )
         }
     }
@@ -110,7 +113,7 @@ private fun TransactionsTopAppBar(
 private fun TransactionsMainContent(
     paddingValues: PaddingValues,
     synchronizer: Synchronizer,
-    transactions: List<TransactionOverview>
+    transactions: ImmutableList<TransactionOverview>
 ) {
     val queryScope = rememberCoroutineScope()
     Column(

diff --git a/gradle.properties b/gradle.properties
@@ -136,6 +136,7 @@ JAVAX_ANNOTATION_VERSION=1.3.2
 JUNIT_VERSION=5.9.3
 KOTLINX_COROUTINES_VERSION=1.7.3
 KOTLINX_DATETIME_VERSION=0.4.0
+KOTLINX_IMMUTABLE_COLLECTIONS_VERSION=0.3.5
 KOTLIN_VERSION=1.9.10
 MOCKITO_KOTLIN_VERSION=2.2.0
 MOCKITO_VERSION=5.4.0

diff --git a/settings.gradle.kts b/settings.gradle.kts
@@ -110,6 +110,7 @@ dependencyResolutionManagement {
             val kotlinVersion = extra["KOTLIN_VERSION"].toString()
             val kotlinxCoroutinesVersion = extra["KOTLINX_COROUTINES_VERSION"].toString()
             val kotlinxDateTimeVersion = extra["KOTLINX_DATETIME_VERSION"].toString()
+            val kotlinxImmutableCollectionsVersion = extra["KOTLINX_IMMUTABLE_COLLECTIONS_VERSION"].toString()
             val mockitoKotlinVersion = extra["MOCKITO_KOTLIN_VERSION"].toString()
             val mockitoVersion = extra["MOCKITO_VERSION"].toString()
             val protocVersion = extra["PROTOC_VERSION"].toString()
@@ -167,6 +168,7 @@ dependencyResolutionManagement {
             library("kotlinx-coroutines-android", "org.jetbrains.kotlinx:kotlinx-coroutines-android:$kotlinxCoroutinesVersion")
             library("kotlinx-coroutines-core", "org.jetbrains.kotlinx:kotlinx-coroutines-core:$kotlinxCoroutinesVersion")
             library("kotlinx-datetime", "org.jetbrains.kotlinx:kotlinx-datetime:$kotlinxDateTimeVersion")
+            library("kotlinx-immutable", "org.jetbrains.kotlinx:kotlinx-collections-immutable:$kotlinxImmutableCollectionsVersion")
             library("material", "com.google.android.material:material:$googleMaterialVersion")
             library("zcashwalletplgn", "com.github.zcash:zcash-android-wallet-plugins:$zcashWalletPluginVersion")