[#1170] Regular transaction flow emitting

CHANGELOG.md

@@ -32,7 +32,10 @@
    - etc.
 
 ### Fixed
-- `Synchronizer.getMemos()` now correctly returns a flow of strings for sent and received transactions.
+- `Synchronizer.getMemos()` now correctly returns a flow of strings for sent and received transactions. Issue **#1154**.
+- `CompactBlockProcessor` now triggers transaction polling while block synchronization is in progress as expected.
+  Clients will be notified briefly after every new transaction is discovered via `Synchronizer.transactions` API. 
+  Issue **#1170**.
 
 ## 1.20.0-beta01
 - The SDK internally migrated from `BackendExt` rust backend extension functions to more type-safe `TypesafeBackend`.

demo-app/build.gradle.kts

@@ -137,6 +137,7 @@ dependencies {
 
     implementation(libs.bundles.grpc)
     implementation(libs.kotlinx.datetime)
+    implementation(libs.kotlinx.immutable)
 }
 
 fladle {

demo-app/src/main/java/cash/z/ecc/android/sdk/demoapp/ui/screen/transactions/view/Transactions.kt → demo-app/src/main/java/cash/z/ecc/android/sdk/demoapp/ui/screen/transactions/view/TransactionsView.kt

@@ -31,6 +31,8 @@ import cash.z.ecc.android.sdk.demoapp.R
 import cash.z.ecc.android.sdk.internal.Twig
 import cash.z.ecc.android.sdk.model.TransactionOverview
 import cash.z.ecc.android.sdk.model.WalletAddresses
+import kotlinx.collections.immutable.ImmutableList
+import kotlinx.collections.immutable.toPersistentList
 import kotlinx.coroutines.flow.flow
 import kotlinx.coroutines.flow.toList
 import kotlinx.coroutines.launch
@@ -41,7 +43,7 @@ private fun ComposablePreview() {
     MaterialTheme {
         // TODO [#1090]: Demo: Add Addresses and Transactions Compose Previews
         // TODO [#1090]: https://github.com/zcash/zcash-android-wallet-sdk/issues/1090
-        // Transactions()
+        // TransactionsView()
     }
 }
 
@@ -72,6 +74,7 @@ fun Transactions(
                 paddingValues = paddingValues,
                 synchronizer,
                 synchronizer.transactions.collectAsStateWithLifecycle(initialValue = emptyList()).value
+                    .toPersistentList()
             )
         }
     }
@@ -110,7 +113,7 @@ private fun TransactionsTopAppBar(
 private fun TransactionsMainContent(
     paddingValues: PaddingValues,
     synchronizer: Synchronizer,
-    transactions: List<TransactionOverview>
+    transactions: ImmutableList<TransactionOverview>
 ) {
     val queryScope = rememberCoroutineScope()
     Column(
@@ -127,7 +130,7 @@ private fun TransactionsMainContent(
                     val memos = synchronizer.getMemos(it)
                     queryScope.launch {
                         memos.toList().run {
-                            Twig.debug {
+                            Twig.info {
                                 "Transaction memos: count: $size, contains: ${joinToString().ifEmpty { "-" }}"
                             }
                         }

gradle.properties

@@ -136,6 +136,7 @@ JAVAX_ANNOTATION_VERSION=1.3.2
 JUNIT_VERSION=5.9.3
 KOTLINX_COROUTINES_VERSION=1.7.3
 KOTLINX_DATETIME_VERSION=0.4.0
+KOTLINX_IMMUTABLE_COLLECTIONS_VERSION=0.3.5
 KOTLIN_VERSION=1.9.10
 MOCKITO_KOTLIN_VERSION=2.2.0
 MOCKITO_VERSION=5.4.0

sdk-lib/src/main/java/cash/z/ecc/android/sdk/block/processor/CompactBlockProcessor.kt

@@ -475,6 +475,11 @@ class CompactBlockProcessor internal constructor(
                     SyncingResult.UpdateBirthday -> {
                         updateBirthdayHeight()
                     }
+                    SyncingResult.EnhanceSuccess -> {
+                        Twig.info { "Triggering transaction refresh now" }
+                        // Invalidate transaction data
+                        refreshTransactions(transactionStorage = repository)
+                    }
                     is SyncingResult.Failure -> {
                         syncingResult = rangeSyncProgress.resultState
                         return@collect
@@ -553,6 +558,12 @@ class CompactBlockProcessor internal constructor(
                         updateBirthdayHeight()
                         SyncingResult.AllSuccess
                     }
+                    SyncingResult.EnhanceSuccess -> {
+                        Twig.info { "Triggering transaction refresh now" }
+                        // Invalidate transaction data and return the common batch syncing success result to the caller
+                        refreshTransactions(transactionStorage = repository)
+                        SyncingResult.AllSuccess
+                    }
                     is SyncingResult.Failure -> {
                         rangeSyncProgress.resultState
                     } else -> {
@@ -598,6 +609,13 @@ class CompactBlockProcessor internal constructor(
         return BlockProcessingResult.Success
     }
 
+    /**
+     * This invalidates transaction storage to trigger data refreshing for its subscribers.
+     */
+    private fun refreshTransactions(transactionStorage: DerivedDataRepository) {
+        transactionStorage.invalidate()
+    }
+
     @Suppress("ReturnCount")
     internal suspend fun runSbSSyncingPreparation(
         backend: TypesafeBackend,
@@ -701,6 +719,11 @@ class CompactBlockProcessor internal constructor(
                 SyncingResult.UpdateBirthday -> {
                     updateBirthdayHeight()
                 }
+                SyncingResult.EnhanceSuccess -> {
+                    Twig.info { "Triggering transaction refresh now" }
+                    // Invalidate transaction data
+                    refreshTransactions(transactionStorage = repository)
+                }
                 is SyncingResult.Failure -> {
                     syncingResult = rangeSyncProgress.resultState
                     return@collect
@@ -1418,8 +1441,8 @@ class CompactBlockProcessor internal constructor(
                                     enhancingResult
                                 }
                                 else -> {
-                                    // Transactions enhanced correctly. Now we return common sync success state.
-                                    SyncingResult.AllSuccess
+                                    // Transactions enhanced correctly. Let's continue with block processing.
+                                    enhancingResult
                                 }
                             }
                             emit(

settings.gradle.kts

@@ -110,6 +110,7 @@ dependencyResolutionManagement {
             val kotlinVersion = extra["KOTLIN_VERSION"].toString()
             val kotlinxCoroutinesVersion = extra["KOTLINX_COROUTINES_VERSION"].toString()
             val kotlinxDateTimeVersion = extra["KOTLINX_DATETIME_VERSION"].toString()
+            val kotlinxImmutableCollectionsVersion = extra["KOTLINX_IMMUTABLE_COLLECTIONS_VERSION"].toString()
             val mockitoKotlinVersion = extra["MOCKITO_KOTLIN_VERSION"].toString()
             val mockitoVersion = extra["MOCKITO_VERSION"].toString()
             val protocVersion = extra["PROTOC_VERSION"].toString()
@@ -167,6 +168,7 @@ dependencyResolutionManagement {
             library("kotlinx-coroutines-android", "org.jetbrains.kotlinx:kotlinx-coroutines-android:$kotlinxCoroutinesVersion")
             library("kotlinx-coroutines-core", "org.jetbrains.kotlinx:kotlinx-coroutines-core:$kotlinxCoroutinesVersion")
             library("kotlinx-datetime", "org.jetbrains.kotlinx:kotlinx-datetime:$kotlinxDateTimeVersion")
+            library("kotlinx-immutable", "org.jetbrains.kotlinx:kotlinx-collections-immutable:$kotlinxImmutableCollectionsVersion")
             library("material", "com.google.android.material:material:$googleMaterialVersion")
             library("zcashwalletplgn", "com.github.zcash:zcash-android-wallet-plugins:$zcashWalletPluginVersion")