Skip to content

Commit

Permalink
skip 32bits builds on electron > abi 64
Browse files Browse the repository at this point in the history
  • Loading branch information
Armaldio committed Dec 11, 2019
1 parent 4548d1a commit 9627ad8
Showing 1 changed file with 16 additions and 10 deletions.
26 changes: 16 additions & 10 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -268,16 +268,6 @@ const run = async (release) => {
continue;
}

/* -- Filtering -- */
// if (version.runtime !== 'nw.js') {
// continue;
// }
//
// if (version.abi !== 77) {
// continue;
// }
/* -- Filtering -- */

console.log(`${version.runtime}@v${version.abi}: `);
console.log('Building...');

Expand All @@ -286,6 +276,22 @@ const run = async (release) => {
for (let j = 0; j < archs.length; j += 1) {
const arch = archs[j];

/* -- Filtering -- */
if (version.runtime === 'electron' && version.abi > 64 && arch === 'ia32') {
console.warn('Electron deprecated 32bits builds for version > 3.1. Skipping');
// eslint-disable-next-line
continue;
}

// / if (version.runtime !== 'nw.js') {
// continue;
// }
//
// if (version.abi !== 77) {
// continue;
// }
/* -- Filtering -- */

try {
await build(version, release, arch);
} catch (e) {
Expand Down

0 comments on commit 9627ad8

Please sign in to comment.