Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date new kings #581

Merged
merged 5 commits into from
Nov 20, 2024
Merged

Date new kings #581

merged 5 commits into from
Nov 20, 2024

Conversation

zsomborfoldi
Copy link
Contributor

@zsomborfoldi zsomborfoldi commented Nov 19, 2024

Summary by Sourcery

Enhancements:

  • Update the chronology data by adding new entries for kings and dynasties, including the Second Dynasty of Lagash, Uruk Dynasty, and Ešnunna Dynasty.

Copy link
Contributor

sourcery-ai bot commented Nov 19, 2024

Reviewer's Guide by Sourcery

This pull request updates the chronological data in brinkmanKings.json by adding new entries and modifying existing ones. The changes primarily focus on adding rulers from the Second Dynasty of Lagash, Uruk Dynasty, and Ešnunna Dynasty that were not previously included in the dataset.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added rulers from the Second Dynasty of Lagash
  • Added Ur-Bau as a new ruler
  • Updated Gudea's dates to 2130-2110
  • Added isNotInBrinkman flag to indicate these rulers were not in original data
ebl/chronology/brinkmanKings.json
Added the complete Uruk Dynasty
  • Added 10 new rulers from the Uruk Dynasty
  • Included rulers like Sin-kašid, Sin-iribam, and Sin-gamil
  • Added isNotInBrinkman flag for all Uruk Dynasty entries
ebl/chronology/brinkmanKings.json
Added the Ešnunna Dynasty rulers
  • Added 23 rulers from the Ešnunna Dynasty
  • Included rulers from Šu-iliya to Ahušina
  • Added isNotInBrinkman flag for all Ešnunna Dynasty entries
ebl/chronology/brinkmanKings.json
Added Rim-Sin II to the Larsa Dynasty
  • Added Rim-Sin II with dates 1740-1736
  • Added reign length of 4 years
  • Marked as not in original Brinkman data
ebl/chronology/brinkmanKings.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. All of the files are larger than we can process. We're working on it!

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 7702 lines exceeds the maximum allowed for the inline comments feature.

Copy link

codeclimate bot commented Nov 20, 2024

Code Climate has analyzed commit a440c89 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (75% is the threshold).

This pull request will bring the total coverage in the repository to 91.4% (0.0% change).

View more on Code Climate.

@zsomborfoldi zsomborfoldi merged commit 6c777a1 into master Nov 20, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants