add AMPS

[zsomborfoldi]

Summary by Sourcery

Add the 'AMPS' project to the research projects and update related test cases to ensure proper integration.

New Features:

• Introduce the 'AMPS' project to the list of research projects in the codebase.

Tests:

• Update test cases to include the 'AMPS' project in various test scenarios, ensuring its integration is verified.

[sourcery-ai]

Reviewer's Guide by Sourcery

This PR adds support for the AMPS (Ancient Mesopotamian Priestly Scholasticism) research project by adding it as a new enum value in ResearchProject and updating related test files to include AMPS in their test cases.

Class diagram for ResearchProject enum update

classDiagram
    class ResearchProject {
        +CAIC: ("Cuneiform Artefacts of Iraq in Context", "CAIC", None)
        +ALU_GENEVA: ("Edition of the Omen Series Summa Alu", "aluGeneva", None)
        +AMPS: ("Ancient Mesopotamian Priestly Scholasticism", "AMPS", None)
    }
    note for ResearchProject "Added AMPS as a new enum value"

Loading

File-Level Changes

Change	Details	Files
Added AMPS as a new research project option	Added AMPS enum value with full name 'Ancient Mesopotamian Priestly Scholasticism' and abbreviation 'AMPS' Updated test cases to include AMPS in project queries Modified fragment factory to include AMPS in default projects Updated DTO tests to include AMPS in project abbreviations	ebl/common/domain/project.py ebl/tests/fragmentarium/test_fragment_repository.py ebl/tests/factories/fragment.py ebl/tests/fragmentarium/test_dtos.py ebl/tests/fragmentarium/test_fragments_search_route.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @zsomborfoldi - I've reviewed your changes and found some issues that need to be addressed.

Blocking issues:

• Invalid syntax in ResearchProject access (link)

Overall Comments:

• In test_dtos.py, the syntax ResearchProject["CAIC", "aluGeneva", "AMPS"].abbreviation is incorrect. Each project's abbreviation should be accessed separately.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🔴 Testing: 1 blocking issue, 1 other issue
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

issue (testing): Test case for 'None' query should include all project indices

The test case for query=None should return [0, 1, 2] since we now have three projects in the test data. Currently, it's not testing the AMPS project in the null query case.

[sourcery-ai]

issue (testing): Invalid syntax in ResearchProject access

The syntax for accessing ResearchProject enums is incorrect. It should be separate entries in a list like [ResearchProject.CAIC.abbreviation, ResearchProject.ALU_GENEVA.abbreviation, ResearchProject.AMPS.abbreviation]

[codeclimate]

Code Climate has analyzed commit 0a50558 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (75% is the threshold).

This pull request will bring the total coverage in the repository to 91.4% (0.0% change).

View more on Code Climate.