Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Test minimum supported BTC version #7448

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

ShahanaFarooqui
Copy link
Collaborator

@ShahanaFarooqui ShahanaFarooqui commented Jul 3, 2024

As suggested by @rustyrussell, Adding another step for testing minimum supported Bitcoin version with clang test suite.

Changelog-None.

@ShahanaFarooqui ShahanaFarooqui added this to the v24.08 milestone Jul 3, 2024
@ShahanaFarooqui ShahanaFarooqui force-pushed the ci-min-btc-check branch 3 times, most recently from 11442ae to e9fdf80 Compare July 3, 2024 20:08
@ShahanaFarooqui ShahanaFarooqui marked this pull request as draft July 3, 2024 20:11
@ShahanaFarooqui ShahanaFarooqui force-pushed the ci-min-btc-check branch 3 times, most recently from 80e9425 to ba5582c Compare July 4, 2024 02:11
@ShahanaFarooqui ShahanaFarooqui changed the title ci: Adding new step to run basic tests on minimum supported BTC version ci: Test minimum supported BTC version Jul 4, 2024
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
@ShahanaFarooqui ShahanaFarooqui force-pushed the ci-min-btc-check branch 3 times, most recently from efcda70 to 7ae08c5 Compare July 12, 2024 19:09
@ShahanaFarooqui ShahanaFarooqui marked this pull request as ready for review July 12, 2024 19:09
Copy link
Collaborator

@niftynei niftynei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parameterize the version number for the job?

.github/workflows/ci.yaml Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
@niftynei
Copy link
Collaborator

documentation on matrix values for github CI jobs: https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs

.github/workflows/ci.yaml Outdated Show resolved Hide resolved
As suggested by @rustyrussell, Adding another step for testing minimum supported Bitcoin version with clang test suite.

Changelog-None.
Copy link
Collaborator

@niftynei niftynei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 5a428b0

@niftynei niftynei merged commit 1e1d072 into ElementsProject:master Jul 16, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants