Bolt catchup 25.09 #8377
Open
Bolt catchup 25.09 #8377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was already disabled by Dusty due to a number conflict with splicing, and the proposal probably needs updating to use quiescence now that is merged. Signed-off-by: Rusty Russell <[email protected]> Changelog-EXPERIMENTAL: The non-functional `experimental-upgrade-protocol` config option.
Dusty patched peer_wire.csv directly, breaking regeneration `make extract-peer-csv`. Signed-off-by: Rusty Russell <[email protected]>
They weren't formatted correctly for bolts/tools/extract-formats.py until this commit, so we had to patch them in manually. Signed-off-by: Rusty Russell <[email protected]>
…tputs. Doesn't change anything for us, since we will already fulfull the incoming HTLCs if we can, but good to note. Signed-off-by: Rusty Russell <[email protected]>
These checks are a SHOULD, but implementing them helps avoid anyone making such weird things in future. Signed-off-by: Rusty Russell <[email protected]>
Spec got stricter. Signed-off-by: Rusty Russell <[email protected]>
Make the payment secret field ('s') mandatory for BOLT11 payment requests,
implementing the requirement specified in BOLT11 spec PR ElementsProject#1242
(lightning/bolts#1242).
This security enhancement prevents payment probing attacks by requiring
all invoices to include payment secrets. Changes include:
1. Adding validation in bolt11_decode_nosig() to reject invoices without
the 's' field
2. Adding payment secrets to all test vectors
3. Updating expected encoded values in test cases to include payment secrets
4. Adding a specific test case that verifies proper rejection of invoices
missing the payment secret field
Changelog-Changed: Made payment secret ('s' field) mandatory in BOLT11
payment requests for improved security.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This incorporates #8221 which needed to BOLT update so the new BOLT quote was detected as valid.
The only user-visible change is the tightened bolt11 parsing requirements, only one of which is Changelog worthy.
Closes: #8221