Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Live player #87

Closed
wants to merge 11 commits into from
Closed

Live player #87

wants to merge 11 commits into from

Conversation

honglu2875
Copy link
Contributor

@honglu2875 honglu2875 commented Dec 17, 2023 •
edited
Loading

  • Added a live player (borrowed a lot of codes from Max)
  • Implemented a sliding window for generation -roll .... It rolls the kv cache when the update position is larger than length.
  • Improved some codes and now greedy_sample returns an iterator with the option of streaming tokens
    Problem:
  • The sliding window generation degenerates very quickly. Probably needs careful debugging to see whether this is from my bug.

Also, we can probably have Max's interactive session in a separate script (since there is no prompt, doesn't fit for the aria.run sample script). We can refactor Max's code #79 after this PR.

@loubbrad loubbrad closed this Jun 10, 2024
@honglu2875 honglu2875 deleted the live_player branch June 10, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@honglu2875 @loubbrad