Add link to contest in jacob pb stats #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't believe this approach works as-is because you're placing an anchor tag as a child of a button tag (the popover trigger) which is invalid HTML. Stuff like this still works a lot of the time, but the invalid HTML causes hydration issues and I want to avoid this in new code. (There are some existing places where this is also happening that need to be fixed) Idk what a good solution here is, it'd probably be fine to just scrap the popover entirely. |
|
|
|
I removed the "Best Scores" title because I couldn't get it to line up correctly when resizing the window, but thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
links to the contest that the pb happened in the jacob pb stats
suggestion
chrome_iHA3KOgJHg.mp4