Skip to content

Commit

Permalink
update cran comments
Browse files Browse the repository at this point in the history
  • Loading branch information
EllaKaye committed Jun 29, 2017
1 parent d82250a commit 18711c9
Showing 1 changed file with 12 additions and 1 deletion.
13 changes: 12 additions & 1 deletion cran-comments.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,21 @@
## R CMD check results
here were no ERRORs and no WARNINGs

There was one NOTE:
There was one NOTE on the local OS X and windows check:
* checking CRAN incoming feasibility ... NOTE
Maintainer: ‘Ella Kaye <[email protected]>’

There was one NOTE on the linux check (on Travis-CI):
* checking installed package size ... NOTE
installed size is 5.7Mb
sub-directories of 1Mb or more:
libs 5.4Mb

This NOTE does not appear on the OS X or windows check.
Moreover, this NOTE also did not appear when checking on a local linux environment (using platform: i686-pc-linux-gnu (32-bit))

My understanding is that this inflation of the libs subdirectory is due to the use of Rcpp. Indeed, some functions of the BradleyTerryScalable package have been written in C++ using Rcpp. They are needed to fit the Bradley-Terry model to large datasets. Without the speed up gained from those C++ functions, this package would not be fit for purpose.

New submission

## First submission
Expand Down

0 comments on commit 18711c9

Please sign in to comment.