fix #47 - wrong permit2 address in the permit2 signed message. #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elnaril
requested changes
Apr 1, 2024
There was a problem hiding this comment.
That's look great to me! But the tests fail because:
- the rpc provider, defined as a secret, cannot be accessed for a PR from a forked repo. And according to this discussion, simple env. variables cannot be accessed neither ... (though I haven't tested it).
- the code does not pass the
isortchecks: imports are strictly formatted. You may want to run it locally first.
I'll by-pass the first issue, but can you please fix the second one?
add verifying_contract parameter to create permit2 message. Signed-off-by: freereaper <[email protected]>
|
done. |
|
@freereaper : All tests passed on the master branch, well done! 💯 Thank you for your contribution! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add verifying_contract parameter to create permit2 message.