Add an environment variable to control test timeout #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The environment variable name is `CARGO_DENY_TEST_TIMEOUT`, it should be able to be parsed into `u64`, otherwise still use 30s as timeout by default.
jaxvanyang
force-pushed
the
jax/feat/timeout
branch
from
961122c to
799cc92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The environment variable name is
CARGO_DENY_TEST_TIMEOUT, it should be able to be parsed intou64, otherwise still use 30s as timeout by default.cargo-deny failed to build for archriscv because of timeout, and I notice that the timeout has been changed before, so I think it may be useful to be able to control the timeout without updating the source code.
And I want to ask if we can increase the timeout? this PR still use the 30s by default. My primary goal is to make cargo-deny build for archriscv. But I'm not sure how long is the minimal time to make it pass. Build log is at archriscv.felixc.at/.status/log.htm?url=logs/cargo-deny/cargo-deny-0.15.1-1.log. Based on a simple comparison of the passed tests between my local machine and the log, 120s (upper bound) may be enough to make it pass.