Mg/setup measurement error #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith a setup, fix lints
jnises
reviewed
Sep 2, 2024
tiny-bench/src/benching.rs
Outdated
| @@ -86,12 +86,15 @@ pub fn bench_with_configuration_labeled<T, F: FnMut() -> T>( | |||
|
|
|||
| fn calculate_iters_and_total_iters( | |||
| cfg: &BenchmarkConfig, | |||
| mean_execution_time: f64, | |||
| mut mean_execution_time: f64, | |||
There was a problem hiding this comment.
call the argument mean_execution_time_ns?
|
@jnises Thanks, could you have another quick peek at the last commit? Realized it's pretty easy to batch and prevent the ram explosion. It didn't affect the measurement overhead in any noticable way either |
jnises
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of Changes
Related Issues
Fixes #10