Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test #104

Merged
merged 19 commits into from
Nov 1, 2023
Merged

Add integration test #104

merged 19 commits into from
Nov 1, 2023

Conversation

trevor-e
Copy link
Contributor

@trevor-e trevor-e commented Nov 1, 2023

No description provided.

@@ -73,7 +72,8 @@ internal object GitHub {
"File $gitHubEventPath doesn't exist"
}

return json.decodeFromStream(file.inputStream())
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an experimental API which we shouldn't use in a public plugin. It was causing very bizarre crashes until I noticed what was happening.

@trevor-e trevor-e merged commit c07b8d4 into main Nov 1, 2023
9 checks passed
@trevor-e trevor-e deleted the telkins/integration-test branch November 1, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants