Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully handle compose errors and record compose preview information for displaying #155

Conversation

rbro112
Copy link
Contributor

@rbro112 rbro112 commented May 24, 2024

No description provided.

Copy link
Contributor Author

rbro112 commented May 24, 2024

Copy link

emerge-tools bot commented May 24, 2024

📸 Snapshot Test

6 added, 20 unchanged

Name Version Added Removed Modified Unchanged Errored Approval
Emerge snapshots sample
com.emergetools.snapshots.sample.debug
1.0 (1) 6 0 0 20 0 ⏳ Needs approval

🛸 Powered by Emerge Tools

@@ -30,6 +30,7 @@ fun TextRowWithIcon(
@FontScalePreviews
@Composable
fun TextRowWithIconPreviewFromMain() {
throw IllegalStateException("This should not be called")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll remove before merge, just for testing

Copy link
Contributor

@chromy chromy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@rbro112 rbro112 merged commit 40508a6 into main May 24, 2024
8 of 9 checks passed
@rbro112 rbro112 deleted the ryan/gracefully_handle_compose_errors_and_record_compose_preview_information_for_displaying branch May 24, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants