[Snapshots] Fix device specs #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
📸 Snapshot Test73 modified, 3 added, 51 unchanged
🛸 Powered by Emerge Tools |
trevor-e
approved these changes
Oct 22, 2024
| } | ||
|
|
||
| private fun dpToPx(dp: Int, scalingFactor: Float): Int { | ||
| return (dp * scalingFactor).toInt() |
There was a problem hiding this comment.
I'm guessing this just needs to be explicitly rounded down.
There was a problem hiding this comment.
I updated to use toInt() in the pixel conversion later. Ended up with the proper dimensions going with that approach
snapshots/snapshots/src/main/kotlin/com/emergetools/snapshots/compose/DeviceUtils.kt
Outdated
Show resolved
Hide resolved
rbro112
force-pushed
the
ryan/fix_device_specs
branch
from
853f85a to
dfaaaf4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes device specs to be true-to-size to reference devices. Also adjusts to properly scale custom specs. Added a repro case of a troublesome client snapshot that wasn't rendering in landscaped.
Verified with a sxs run against Google's compose preview snapshotting library, Emerge matches 1:1 on all device specs now. Android Studio images (copied directly from the previews) appear smaller, and dimensions do not match the reference device specs, so I believe matching the expected device dimensions like we do now is preferred over 1:1 matching of AS.
Also checked all reference devices against the outputted dimensions from Emerge snapshots after this change and all match 1:1.