Update compose invoker to better replicate PreviewActivity behavior #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
rbro112
force-pushed
the
ryan/prepare_for_snapshots_release_1.3.0-beta02
branch
from
9525ee1 to
c576c30
Compare
rbro112
force-pushed
the
ryan/update_compose_invoker_to_better_replicate_previewactivity_behavior
branch
from
e4eac88 to
2fd84fe
Compare
rbro112
force-pushed
the
ryan/update_compose_invoker_to_better_replicate_previewactivity_behavior
branch
2 times, most recently
from
068c9de to
2b01646
Compare
Base automatically changed from
ryan/prepare_for_snapshots_release_1.3.0-beta02
to
main
October 25, 2024 05:00
rbro112
force-pushed
the
ryan/update_compose_invoker_to_better_replicate_previewactivity_behavior
branch
from
2b01646 to
358334e
Compare
📸 Snapshot Test142 unchanged
🛸 Powered by Emerge Tools |
rbro112
force-pushed
the
ryan/update_compose_invoker_to_better_replicate_previewactivity_behavior
branch
from
a09314f to
8babfe8
Compare
trevor-e
approved these changes
Oct 25, 2024
rbro112
deleted the
ryan/update_compose_invoker_to_better_replicate_previewactivity_behavior
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our custom implementation of reflective invoking was hitting some snags around typing/param resolution. After looking into how stock Android compose tooling does it, I figured it would be best for us to replicate their's as close as possible:
This brings us up to almost a 1:1 invoking pattern as them, while taking into account some of our first-class compose args/helpers. This has resulted in a nearly 100% success rate with existing client apps I've tested against.