Add distribution support to gradle-plugin #297
+253
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chromy
force-pushed
the
chromy/2024-10-22-distro-gradle
branch
4 times, most recently
from
b4a7497 to
a9ea833
Compare
chromy
force-pushed
the
chromy/2024-10-22-distro-gradle
branch
2 times, most recently
from
5faa01b to
c82c886
Compare
chromy
force-pushed
the
chromy/2024-10-22-distro-gradle
branch
from
c82c886 to
566216e
Compare
chromy
changed the title
rbro112
reviewed
Dec 17, 2024
| apiKey.set(System.getenv("DISTRIBUTION_API_KEY")) | ||
|
|
||
| // Optional, defaults to 'release' | ||
| tag.set("release") |
There was a problem hiding this comment.
Tag doesn't seem to be relevant currently - I'd suggest removing it until we have an upload-related task around distro to avoid confusion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.