Lower compose version to avoid breaking change added in 1.7.0 #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
1 build decreased size
Emerge snapshots sample 1.0 (1)
|
| Item | Install Size Change | Download Size Change |
|---|---|---|
| 🗑 androidx.compose.foundation.text.input | ⬇️ -246.7 kB | ⬇️ -82.2 kB |
| 🗑 lib | ⬇️ -37.4 kB | ⬇️ -17.7 kB |
| 🗑 androidx.compose.ui.graphics.layer | ⬇️ -47.0 kB | ⬇️ -15.7 kB |
| androidx.compose.material3.TextFieldDefaults | ⬆️ 28.4 kB | ⬆️ 9.5 kB |
| 🗑 androidx.lifecycle.compose | ⬇️ -25.8 kB | ⬇️ -8.7 kB |
View Treemap
🛸 Powered by Emerge Tools
Comment trigger: Size diff threshold of 100.00kB exceeded
📸 Snapshot Test3 modified, 139 unchanged
🛸 Powered by Emerge Tools |
trevor-e
approved these changes
Nov 7, 2024
rbro112
deleted the
ryan/lower_compose_version_to_avoid_breaking_change_added_in_1.7.0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.7.0 of
compose-runtime(any compose-bom after2024.08.00) has a breaking change in our snapshots SDK when targeting an app with 1.6.8 or lower (bom2024.08.00).When building our SDK with a 1.7.0+, a
rememberComposableLambdafunction is called that was added in 1.7.0. When our snapshots SDK is used as anandroidTestImplementationdependency against an app with a lower compose version, this function is not present, which leads to aNoSuchMethodErrorupon trying to invoke the snapshot.For now, this should be able to be fixed with a simple version drop, and longer term we can work through a more elegant solution that can allow us to ship with whatever version of compose we'd like, while supporting any client version.