Use Gradle TestKit Support Plugin for testing #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses some of the convenience provided by using [Tony's Gradle TestKit Support Plugin.](https://github.com/autonomousapps/dependency-analysis-gradle-plugin/tree/main/testkit) The goal of this change is to allow us to rewrite some of the tests to stop using `GradleRunner.withPluginClasspath()`. See point #1 in the above readme.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
rbro112
approved these changes
Feb 17, 2025
runningcode
deleted the
no/use_gradle_testkit_support_plugin_for_testing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses some of the convenience provided by using Tony's Gradle TestKit Support Plugin.
The goal of this change is to allow us to rewrite some of the tests to
stop using
GradleRunner.withPluginClasspath(). See point #1 in theabove readme or for more information on issues with
withPluginClasspathsee these issues: gradle/gradle#28285gradle/gradle#22466
I believe that the mixing of the classpath is causing some tests to succeed even though they should fail. We shall see. Either way this PR has revealed that this is a problem.